Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

QR Code Component Challenge using HTML and CSS

foundation
Nicolás Herrera•70
@herreranicolas
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


This is my first challenge.

What do you think I can do better?

Feel free to give me your feedback!

Thanks in advance!

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Jessica•880
    @perezjprz19
    Posted over 3 years ago

    I would just work on clearing your error report. You can make the bold text an h1 and wrap your container div in a <main> tag. That should resolve the issues.

    Other than that, just keep practicing until you can move on to building responsive layouts :-).

    FYI - The image is touching the sides of the container on my phone screen.

    Still a good job though 😀 Keep coding.

    Marked as helpful
  • Anosha Ahmed•9,300
    @anoshaahmed
    Posted over 3 years ago

    Hey good job on this challenge! Your report above shows a few issues though:

    • wrap everything in your body in <main> ... OR use semantic tags! .... you can also give role="" to the direct children of your <body> but that's a little frowned upon... Read more here
    • have at least one <h1> in your code

    Here's my repo for future reference.

    Hope this helps :)

    Marked as helpful
  • P
    Jordan Phillips•425
    @JordanPhillips-hub
    Posted over 3 years ago

    Try putting the blueish grey background colour on your body instead of the .container this should fill make the whole page that colour and get rid of the white patch at the bottom.. Looks good though.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub