QR Code Component created in HTML and SCSS

Community feedback

• 

  Shashree Samuel•8,860

  @shashreesamuel

  Posted over 3 years ago

  Hey good job completing this challenge, however I have the following suggestions

  • The image is supposed to be contained within your card

  • The color of the card description does not match the color specified in the style-guide.md file

  • The card title is supposed to have a heavier font weight

  In terms of your accessibility issues simply wrap all your content between main tags

  I hope this helps

  Cheers Happy coding 👍

  11

  Marked as helpful
• 

  Jeuri Morel•1,385

  @JeuriMorel

  Posted over 3 years ago

  Hi @athirasarman, nicely done.

  You have a few accessibility issues which should be quite easy to fix.

  • First, change the <div class="content"></div> to <main class="content"></main>. Remember that all page content should be contained by landmarks and that the page should have one main landmark.
  • Make the <p class="header-text"></p> an h1. Page should contain a level-one heading.

  01

  Marked as helpful
• 

  Hikmah•1,070

  @Hikmahx

  Posted over 3 years ago

  Hi Athira. Great solution. I just want to suggest for a better user experience, I think you should darken the color of the paragraph text to something like color: #b8bbc0;. Also, instead of wrapping the header-text and content-text classes in a parent span tag, it's better to use a div tag. Doing so would remove the HTML issues on your app.

  01

  Marked as helpful