Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 9 months ago

QR Code Component

sass/scss
Ahmed Aziz•90
@Abo3bazez
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I'm very happy with the time I completed the challenge in.

What challenges did you encounter, and how did you overcome them?

The QR image was a bit annoying to make responsive, and the container's width property, which I set to fit-content, didn’t work. But I managed to handle the problem—maybe I missed something obvious.

What specific areas of your project would you like help with?

image responsive

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    MikDra1•7,450
    @MikDra1
    Posted 9 months ago

    If you want to make your card responsive with ease you can use this technique:

    .card {
    width: 90%;
    max-width: 37.5rem;
    }
    

    On the smaller screens card will be 90% of the parent (here body), but as soon as the card will be 37.5rem (600px) it will lock with this size.

    Also to put the card in the center I advise you to use this code snippet:

    .container {
    display: grid;
    place-items: center;
    }
    

    Hope you found this comment helpful 💗💗💗

    Good job and keep going 😁😊😉

    Marked as helpful
  • P
    Huy Phan•3,430
    @huyphan2210
    Posted 9 months ago

    Hi, @Abo3bazez I saw your solution and I have some thoughts:

    • I assume the "container" you're referring to is .qr-container. You're currently using @media screen and (min-width: 375px) to set its width to 17.1875rem, which is a fixed size. If you want the image to be fully responsive (as you're using max-width: 100% on the image inside the .qr-container), the container itself needs to be responsive too. Consider setting the .qr-container width to a relative value, like 90%, and then apply a max-width with a reasonable absolute value. For example:
    .qr-container {
        width: 90%;
        max-width: 400px;
    }
    

    Let me know if that works!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub