QR Code Component using CSS custom properties and Flexbox

Solution retrospective
I am proud that I am hosting my solution for the first time live on GitHub Pages and that I can work now with Figma designs
What challenges did you encounter, and how did you overcome them?I was working for the first time with Figma and found the Figma for developers: How to work with a design file link really helpful.
What specific areas of your project would you like help with?One of the ideas for the challenge was to focus on writing semantic HTML and I would like to know how can it be applied to a card component we were writing.
Also I would like an overall feedback on what can be improved as there is always place for improvement :-).
Thank you.
Please log in to post a comment
Log in with GitHubCommunity feedback
- P@danielmrz-dev
Hello @ikokolius!
Congrats on completing the challenge! ✅
Your solution looks great!
I have a suggestion for improvement:
📌 Think about using
<main>
to wrap your main content instead of<div>
.Imagine
<div>
and<span>
in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.This change might not have impact on how your page looks, but it'll make your HTML code clearer and help with SEO and accessibility.
Hope that's helpful!
Keep up the great work!
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord