Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 1 month ago

QR Code component using HTML and CSS

Viktor Rumenov•60
@TamarawGuy
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Rohan T George•230
    @19Rohan97
    Posted about 1 month ago

    Awesome work! You've replicated the design exceptionally well — your attention to detail and execution really stand out. It's evident that you understand the layout structure and styling principles well. Keep up the great work!

    ✅ One Suggestion – Simplify with Universal Selector *

    In your CSS, I noticed you've explicitly listed out every single element (like html, body, div, h1, p, etc.) for resetting default styles. While this is thorough and ensures cross-browser consistency (especially for older projects), it’s also quite verbose and can be simplified in modern workflows.


    🔁 Recommendation: Use the Universal Selector

    Instead of:

    html,
    body,
    div,
    span,
    applet,
    object,
    iframe,
    ... (and many more)
    

    You can use:

    * {
      margin: 0;
      padding: 0;
      box-sizing: border-box;
    }
    

    This does the same job more efficiently by:

    • Removing default margin and padding from all elements
    • Setting a consistent box-sizing model (border-box) which is easier to manage when working with padding and widths

    🕹️ Optional for Older Browser Compatibility

    If you're specifically targeting older browsers or legacy layouts, it’s still valid to use a detailed reset like the one you provided. It follows the Eric Meyer reset pattern, which was popular before modern CSS tools became mainstream.

    However, for most current web development scenarios, especially in a learning or modern portfolio project, the universal * selector or a CSS Reset/Normalize file is enough.


    🧠 Pro Tip

    For even better practice, combine the universal selector with ::before and ::after to cover pseudo-elements:

    *, *::before, *::after {
      margin: 0;
      padding: 0;
      box-sizing: border-box;
    }
    

    This ensures full consistency in how box dimensions are calculated — even for decorative elements like icons or overlays.

  • Lalalaloo•40
    @Lalalaloo
    Posted about 1 month ago

    This looks exactly like the designn

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub