QR code component

Community feedback

• 

  Kinga Miśkiewicz•160

  @codingbeary

  Posted about 2 years ago

  Hi! You did great! :) I have a few tips for you how you can improve this project:

  • You can use exactly the same background colour as the one in the design by using colour picker or you can find this value in the starter code itself in a file called "style guide" (or something similar, I don't remember exactly, but if you have trouble finding it let me know, I'll check it for you :)
  • To center your project perfectly you can use: body{ display: flex; justify-content: center; align-items: center; min-height:100vh; }
  • I can see you have a bit too much white space on the bottom of the card, but you can fix it by removing height: 70vh. from your container
  • Remember about using semantic tags like <header> <main> etc. for better accessibility. You can find all information about semantic HTML here: https://www.w3schools.com/html/html5_semantic_elements.asp It's important to use proper semantics in HTML to make sure search engines and screen readers don't have problem with understanding the contents of your page. :)

  I hope those tips were helpful :) Great work btw, keep it up! :)

  31

  Marked as helpful