Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 1 year ago

QR Code using CSS

accessibility, foundation
P
yinnie•320
@wcyin9
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I'm most proud of having the final product look very similar to the design. Having access to the figma file is very helpful to the process. Next time I should organize all the font styles and colors before I start coding so I don't have to go around looking for them in the middle of coding.

What challenges did you encounter, and how did you overcome them?

I had a bit of trouble with flex. I mistakenly tried to center the container in the child instead of the parent class, which ended up in me centering it horizontally only. I figured out that display: flex should have been in the parent, and upon changing it, I successfully centered it vertically.

What specific areas of your project would you like help with?

I am not sure if the code I wrote could have been written more efficiently. I think I have a habit of writing excess code, or doing things in a way that use more code than necessary. If anyone has more effective ways that I could implement, please let me know.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Bryan Li•3,530
    @Zy8712
    Posted about 1 year ago

    Your site looks great and your code is really minimal. Nice work!

    Some things I'd suggest you to change:

    • use <h1> instead of <h3>, heading tags are meant to be used in order from h1 to h6 without any skips. All of these heading tags come with default font sizes which can be modified using the font-size attribute
    • the use of the <article> tag is perfectly fine, though most people would include the <main> tag for their page's main content

    Hope you find this feedback useful 👍

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub