Skip to content
Submitted over 2 years ago

QR Code using css media query

react
Moh Lutfi Fauzi•130
@MohLutfiFauzi
A solution to the QR code component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

The most difficult thing in this task is to ensure the distance between the components because we are not given instructions for it

Code

Please log in to post a comment

Log in

Community feedback

  • Flaviu Dragomir•150
    @FlaviuD94

    Hi, nice to have you around! Welcome to Frontend Mentor Coding community Your solution looks great, you can still do some things to it:

    • replace the <h2> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.
    • you can use the <main> instead of using <section>.
    • for measurement you can use ruler tool from Photoshop.

    I hope it will help you, Enjoy coding!

    Marked as helpful
  • Lucas 👾•104,160
    @correlucas

    👾Hi Moh, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!

    Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

    • Use <main> instead of a simple <div> this way you improve the semantics and accessibility showing which is the main block of content on this page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning.
    • Replace the <h2> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.
    • Add a margin of around margin: 20px to avoid the card touching the screen edges while it scales down.
    • Use relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

    Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

    ✌️ I hope this helps you and happy coding!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord