Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code using html css

@milosshomy

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any feedback?

Community feedback

Mo 840

@MohamedAridah

Posted

Hello @milosshomy,

I have some notes for you:

  • don't use height for .card this causes big space in the bottom of your card. let content inside the card take the suitable spaces like padding and margin instead.

  • when you remove height for the .card div you will need to add padding-bottom for the .card-content div

  • remove margin-bottom for the image. you can use it for .card-image div itself.

For Accessibility issues:

  • wrap .card div inside <main> tag.

  • use <h1> heading level instead of using <h3> heading level.

  • you can see My solution for this challenge it may be helpful for you..!

I hope this wasn't too long for you, hoping also it was useful😍.

Goodbye and have a nice day.

Keep coding🚀

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord