@faha1999
Posted
Hello, Andrés Congratulations on finishing this project. It's lovely and great on the whole! Just a little tip:
- You might want to use semantic tags like the
<main>
to wrap your code, instead ofdiv
. like
<main class="card"></main>
<footer class="attribution"></footer>
This would help improve accessibility.
- add the below styles to the
body
. It will center everything
body {
justify-content: center;
align-items: center;
display: flex;
min-height: 100vh;
flex-direction: column;
}
-
remove
margin: 50px auto;
from the.card
-
Instead of using
px
, use relative units likerem or em
to get better performance when the information on your page needs to be resized for multiple screens and devices.REM
andEM
apply to all sizes, not justfont-size
. You can code your entire page inpx
and then, at the very end, use the VsCode pluginpx to rem
to perform the automatic conversion px to rem
I hope it will work. Happy coding.