Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 4 months ago

QR Component using React, NextJS, and tailwindcss

next, tailwind-css, react
P
Erik S. Carlsten•290
@ecarlste
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

This is my first challenge on this website so I would have to say the thing I'm most proud of is just getting started. I'm primarily a backend and DevOps/Platform engineer although I've always been drawn to UI work. So I'm just excited to be working on what I've always wished I worked on more.

I typically work in type safe languages and I build most of my hobby backends as well as frontends in TypeScript. I wish I would have converted this repo to TypeScript ahead of time. I also would like to get faster at testing UI as I'm less familiar with frontend testing than I am with backend.

I would also extract the QR code component out into an actual React component that I would pass potentially pass the text and QR code to as props if I were building this to reusable, so I'll be refactoring it.

What challenges did you encounter, and how did you overcome them?

The only bit that felt challenging to me about this particular component was how to get the white containing div to size how I wanted it to around the image and get the text to look right. I ended up using the tailwind directive max-w-xs to get the white container to shrink down and I'm thinking there is likely a better way to handle it than what I've been able to get working.

I primarily just spent a little bit of time looking through some tailwind docs to see what would might be able to force the dive to shrink down as tightly as it could around the QR code image.

What specific areas of your project would you like help with?

I'm clearly no expert in React, NextJS, or tailwind. I know just enough to get things done, albeit likely not the best way. I'd love to get some feedback around how I organized the usage of CSS mostly, although I'd love to see how someone with more experience with tailwind would have organized the className attributes to achieve this.

I was also a bit unsure about the use of the Google font and how I imported it using next/font/google and how I combined it with inline className use. I'd love to see how a someone with extensive tailwind experience would do this.

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    BlonoBuccellati•320
    @BlonoBuccellati
    Posted 4 months ago

    Great work! I'll use this as a reference. Thank you! I noticed that outfit.className is applied twice in your code. If you apply it to the parent <div>, it will automatically be inherited by both child elements, making the code cleaner. Just a small suggestion—what do you think?

    // Before
    <h1 className={`text-slate-900 text-[22px]/7 ${outfit.className} font-bold`}>
    {/* some JSX */}
    <p className={`text-slate-500 text-[15px]/5 ${outfit.className}`}>
    
    // After
     <div className={`px-3 pt-1.5 space-y-4 ${outfit.className}`}>
    
    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub