qr-code-component-main
Solution retrospective
I'd appreciate if you can take a look at my solution and give me some feedback. Constructive criticism is what I'm looking for! don't hesitate to be brutally honest :)
Please log in to post a comment
Log in with GitHubCommunity feedback
- @abhik-b
👋 Hello Ammar , Your Solution looks perfect to me, Well Done 🤩!!! However I think if you remove the margin from the body (use
margin:0;) you solution would look nicer on mobile screens as well.Please keep up this amazing work 👍
Marked as helpful - @NaveenGumaste
Hay ! Good Job you made it look nearly perfect to the preview
These below mentioned tricks will help you remove any Accessibility Issues
-> Add Main tag after body like it should be your container
-> For 1st heading or h1 tag, use header tag and then inside the header put your h1 or h2 etc
-> But use header tag only once in main heading element.
Keep up the good work!
- P@JordanPhillips-hub
hey Ammar the card looks good although I am not sure if you are getting HTML tags and classes mixed up you should remove the <container> and <card> as these are not tags try wrapping them with a <div> </div> and giving them a class like this <div class="card"></div>, <div class="container"></div>, if you wished to you could remove those altogether as you already have your <main> tag as a wrapper and do not need the other two.. hope this helps you. Here is a good source about HTML tags and when to use them.
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord