Skip to content
Submitted over 2 years ago

qr-code-image with flexbox

Ong Jun hong•20
@MaxOng94
A solution to the QR code component challenge
Preview (opens in new tab)Code (opens in new tab)
Code

Please log in to post a comment

Log in

Community feedback

  • Abdul Khaliq 🚀•72,380
    @0xabdulkhaliq

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    ESSENTIALS ♻️:

    • This solution has generated accessibility error reports due to lack of title tag inside html element
    • The <title> tag defines the title of the document. The title must be text-only, and it is shown in the browser's title bar or in the page's tab.
    • The <title> tag is required in HTML documents, The contents of a page title is very important for search engine optimization (SEO). <html> element must have a title tag, so fix it by adding,
    • <title>QR Code Component</title> inside the html

    HTML 🏷️:

    • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which causes lacking of landmark for a webpage
    • So fix it by replacing the <div class="container"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.
    • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers
    • For example:
      • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
      • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

    HEADINGS ⚠️:

    • This solution has also generated accessibility error report due to lack of level-one heading <h1>
    • Every site must want at least one h1 element identifying and describing the main content of the page.
    • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
    • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

    CSS 🎨:

    • Looks like the component has not been centered correctly. So let me explain, How you can easily center the component without using margin or padding.
    • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states, Just add the following style rule
    body {
    display: grid;
    place-items: center;
    min-height: 100vh;
}
    • Now remove these styles, after removing you can able to see the changes
    .container {
   margin: 25vh auto;
}
    • Now your component has been properly centered

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    Marked as helpful
  • Sumanth Chandana•720
    @sumanth-chandana

    Hi mate!, congrats🎉 on completing the challenge. Better take care about following points.

    • Always check Frontendmentor Report Generator issues after submitting the project for removing errors and warnings.
    • Maintain a <title> tag in your page by default in HTML semantic.
    • Use the alt (alternate text) attribute as mentioned in your Accessibility Report. alt attribute is used for Screen readers applications.
    • Why does alt attribute matter? Read here.
    • To avoid accessibility issues "All page content should be contained by landmarks" use code as :
     <body>
    <main>
        ---your code here----
    </main>
  <footer>
  </footer>
</body>

    (why does <main> matter? Read here )

    • For proper centering the container(whole card) vertically and horizontally you can also use the following simple block of code use code:
    body{
    display: flex;
    align-items: center;
    justify-content: center;
    height: 100%;
}

    or

    body {
    min-height: 100vh;
    display: grid;
    place-content: center;
}
    • When we open the GitHub repository link, you will find an About Section on the right side. There, also include a live preview link of your project. It is better for someone to check your live project while interacting with code.

    I hope you will find this Feedback Helpful.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord