React app with Flexbox and SCSS

Community feedback

• 

  htmlHxcker•70

  @htmlHxcker

  Posted almost 4 years ago

  Hi, Awesome work on this challenge, I understand that it's a bit complex and so you did a lot with this so good job on that. I did notice a few bugs though, which while they don't break the functionality of the app could make the usability of the app a smoother experience. Here are the things I noticed.

  1. On Devices with a width less than 320px (Mobile S in Chrome DevTools) the blue background doesn't take up 100% of the screen and instead gets cut off towards the bottom, this also happens when results are displayed.
  2. Sometimes, if I double click on a covered tile, it automatically opens up the solution (To be honest I didn't want to tell you about this one just because it seemed like a fun way to hack the game LOL)
  3. Speaking of Tiles; If I clicked too fast I found that I could get 3 tiles to be opened all at once, inversely, sometimes if I click too fast it closes other tiles and opens just one tile(The last tile I clicked).
  4. You did a good job! Now I have to give a disclaimer, I didn't go through your code because I am also working on this challenge (I in fact had to use my mentor points to view your solution out of curiosity) and didn't want to cheat but from what I can see as an end-user, this is very polished and well done, the points above are things you could work on if you feel like since they don't necessarily break the solution, Hopefully, if I complete my solution then I can look through your code and maybe you could look through mine too, Cheers!.

  31

  Marked as helpful
• 

  

  Matt Studdert•13,611

  @mattstuddert

  Posted over 3 years ago

  You've done a brilliant job on this challenge, Michael! It's great to hear you enjoyed working through it. I've just spent a good 10 minutes playing, so you've done a superb job making the game flow nicely!

  My main recommendation would be to add some focus states to the buttons to allow for keyboard navigation. There aren't any focus states at the moment, so it's not possible to tell which button element has focus.

  Keep up the excellent work! 👍

  33