P
ApplePieGiraffe• 30,545
@ApplePieGiraffe
Posted
Hey, great job once again, Felipe Oliveira! 🙌
Your solution looks good, responds well, and everything works great! 👏
Keep coding (and happy coding, too)! 😁
0
Design comparison
Solution retrospective
Any feedback is appreciated!
Community feedback
Arturo Simon• 1,785
@artimys
Posted
Hello again Felipe, amazing job on the challenge.👍👍 It functions and responds well. As usual feedback below.
Accessibility
When I enabled some tablets, I tried tabbing through them and was unable to do so. Mainly due to the.table tablet--remove-icon and .tablet elements being divs. I would suggest using a button or anchor tag. By default they would have keyboard support for spacebar/enter keydown and tabbing.
Design
- The
h1.Job__positioncould use an anchor tag with a hover state. - Minor changes like adding a font-weight to your tablets and maybe decrease font size for your
Job__meta
Great job 👍, can't wait to see your next solution
0
Felipe OG• 730
@felipeog
Posted
Hello, @artimys!
Good point on the accessibility, I didn't do the tabbing test. Good catch on the design details too.
Thanks for the feedback!
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord