@mattstuddert
Posted
Hey Clinton, awesome work on this challenge, you've done a really good job! How did you get on working with React? Did you like using it?
I've only got a couple of suggestions, but both aren't related to React:
- If you search for countries and get 2 returned, they are spread across the page because you're using
justify-content: space-between;
on the container. I would just let them maintain the natural flow withflex-start
. - You're using a
div
for your custom dropdown, which means that people who need to use the keyboard or other assistive technologies to navigate the page can't access it. I would recommend research accessible HTML patterns for custom dropdowns to get this working for all users.
I hope these tips help. Keep up the great work! 👍
@DarkFM
Posted
Thanks for the feedback @mattstuddert. I will look into fixing the issues you mentioned.
As for the project itself, I found it to be the perfect difficulty for learning react.
Really apreciate the work you've done here.
@mattstuddert
Posted
@DarkFM I'm really happy to hear that! It's great that you like the site and are finding the challenges useful 🙂