Hi Danny,
Definitely address the html issues raised in your report - those aren't habits you wanna get into 😉
I'd also tweak the vertical padding and change your shadow on the box (color, placement and spread) to more closely match the designs
These might also help:
- remove min width off your wrapper
- change height to min height on your card
Overall though, this is a really good first challenge. Your html is nicely structured (minus the validation errors already flagged) and good use of BEM in your css. Well done ☺
@Deminal
Posted
@grace-snow
Hi Grace,
Thank you so much for the feedback! Most of (3/4) the HTML validation errors are me attempting to add alt tags and a tab-index to the entire card, attempting to make it more accessible. Are these features unnecessary or is there a better way to implement this?
@Deminal adding attributes to elements that shouldn't have them actually makes them less accessible believe it or not 😊
If you use good semantic html - like headings in order, having text in paragraphs, lists in lists, using interactive elements for things that are meant to be interactive, and writing descriptive alt text on images - are all tee accessibility you need.
