Hi SERPET-ENG
So far so good with your project, here are some few recommendations to consider:
- a project should consist of
Landmark regions
elements , among them includesheader, main and footer
. For this project , you should at least have themain
element. Landmark regions are important for organisation and structure of a webpage. The MDN doc are a good reference for this topic. Change the div with theclass="main"
into yourmain
element. - Responsive images are not created using Javascript, do not use Javascript for content that should be done with HTML or CSS. You will need to look at the
picture element
in most cases, it is a topic that you will need to continually visit. One of my main source is Responsive images. - alt values should describe the message that is in the image and should always avoid words like
image, icon, picture etc
,as these words are automatically used by assistive technology. - i consider a heading element to be a short description of what is to come, hence a number that is a number does not provide that vital information to users.
- Heading elements , follow a sequential order where an
h1
is followed by anh2
. Using the same logic anh2
can only be followed by an h3 and so forth, hence we cannot start with anh5
heading element and then somewhere down the code have an h1. Use CSS to style the content to match the desired font size - the attribution can be changed into the
footer
element. - keep specificity as low as possible by mostly targeting classes for styling
- once again this challenge does not need Javascript unless you want to add additional features when the button has been clicked
Marked as helpful
@SerPet-eng
Posted
Thank you very much! (●'◡'●) @ChamuMutezva for the recommendation.
This was indeed helpful. After reading your comments about this and give some thought, I'm going to make some refactors and add this to my project.
I also going to take some notes about this. So that, if I ever encounter this kind of issue, I can make sure to take action immediately.