Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive card using CSS

@Vanessa-SC

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Ahmed Bayoumi 6,800

@Bayoumi-dev

Posted

Hey Vanessa, It looks good!... You have accessibility issues that need to fix.

  • Page should contain a level-one heading, Change <div class="card-title">Equilibrium #3429</div> to <h1 class="card-title">Equilibrium #3429</h1> You should always have one h1 per page of the document... in this challenge, you will use h1 just to avoid the accessibility issue that appears in the challenge report... but don't use h1 on small components <h1> should represent the main heading for the whole page, and for the best practice use only one <h1> per page.
  • All page content should be contained by landmarks, Contain the attribution with <footer>.
<footer>
   <div class="attribution">
      //...
   </div>
</footer>

Hope this help!... Keep it up👍

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord