@rngueco
Posted
Hi Franziska! 👋
Great job on this! It's definitely one of the harder newbie challenges out there because of the positioning, but you did well!
As for ARIA, some developers still definitely use ARIA. Here is WebAIM's guidelines for ARIA use. WebAIM's website in general helped me lots regarding accessibility. There's also the A11Y Project if you prefer that.
As for your HTML, you could make it more semantic by putting the FAQs in a more semantic structure, like a list <ul> or <ol> 🙂 Typically all webpages should have a main heading wrapped in <h1> that denotes the main topic of the page, so it would make sense to have one in this project too. A good reminder is to not skip heading levels (i.e. going from <h1> straight to <h3> without using <h2> is not good practice).
Marked as helpful
@franziskawich
Posted
@rngueco
Hi Riyana,
thank you very much for your feedback and recommendations. (: I saw that you did this challenge without JS before I started it and it motivated me to try my luck myself ("If she can do it...!"). ^^
I was thinking about using an ol/ul-list at first. Then I've read somewhere that the summary-element is an list-item already and I thought that would suffice, but it probably does not. This was the main reason why I was looking for a website about accessibility. I will check your recommendations and will do some reading on it. I know that these are still very small projects but why not start with accessibility in mind early on so it becomes second nature in bigger challenges. I used a h1 and h2s at the beginning and then I felt like that this FAQ is just a component of a bigger website and I changed them to h2/h3s, but you are right, I should see this challenge as its own website. I will change it back right away.
I wish you all the best. Maybe we see/read each other again in future challenges.
