Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 6 months ago

Responsive Full News Page project

Crystalis89•460
@Crystalis89
A solution to the News homepage challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

That completed the first project that was a full page not just a single element. Only part that took a bit of research was how to make the sidebar nav properly slide in and out smoothly due to it not being able to animate switching in and out of display:none so needing to add a few extra lines to make it work.

What challenges did you encounter, and how did you overcome them?

Only part I was not sure about was there not being anything that seemed like could single it out to be THE h1, I settled with making one for the Headline section and have it visually hidden to function as a Landmark for Screenreaders.

Also feel like may have made a mistake on the mobile layout due to the nav not being visible til press the button which seems like bad design for those using a screenreader, even if said button says so in the image alt text.

I originally tried having the sidebar active at all times but hidden visually til click to act as the nav for both layouts for screenreader usage with the header nav being hidden from SR but that runs into issue of invisible tab navigation targets so eventually changed it.

Code
Loading...

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Trần Thành Danh•1,500
    @TranDanh1122
    Posted 6 months ago

    that good, but you have some problem

    • spacing need improve
    • padding need improve
    • need to set max-width to you content, not body (that trick like .container in bootstrap), makesure body always 100% height and width
    • refactor code if you have time, i feel hard a bit when try to understand your css file
    • overlay of sidebar in mobile no need to move, it need position fixed and 100% width and height
    • you can review my solution, maybe it helpful
    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub