Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

Responsive landing page using CSS Flexbox

accessibility, bem, lighthouse
Rebecca Padgett•2,100
@bccpadge
A solution to the Base Apparel coming soon page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hey everyone,

This my solution to Base Apparel Coming Soon Page using HTML, CSS & JavaScript. The only issue I had doing the project is placing the bg-pattern-desktop.svg on desktop. All feedback is welcome and greatly appreciated.

Thanks,

Rebecca

Code
Loading...

Please log in to post a comment

Log in with GitHub

Community feedback

  • Jeuri Morel•1,385
    @JeuriMorel
    Posted over 1 year ago

    I've got a few suggestions for changes to your CSS that should fix some of the img issues, like the stretching that occurs when resizing window and should keep the img ratio intact.

    I would replace all the style declarations on .showcase img with a simple height: 100%; and change the max-width: 100%; on the img, picture, svg selector with width: 100%;. A side effect of this is that the logo image will end up being too large at certain sizes, so select it and give it a width: auto;

    In the media query for .container I would add a few declarations so it ends up looking like this:

    @media (min-width: 75em)
    .container {
        flex-direction: row;
        height: 100vh;
        overflow: hidden;
        align-items: center;
    }
    

    I would then remove the media query for the .showcase img.

    This isn't necessary, but I would change the breakpoint for all current media queries from 75em to something like 50em because as it currently is you're using the mobile image at relatively large screen sizes with makes it really blurry.

    Adding the following query will line up the top of the image with the top of the page to keep the face properly in view.

    @media (min-width: 75em)
    picture.showcase {
        align-self: flex-start;
    }
    

    You can play around with the breakpoint numbers to something that looks good to you.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub