Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive landing page using HTML and CSS

@SeyideHundeyin


Design comparison


SolutionDesign

Solution retrospective


Hi, this is my first project.

I would appreciate any feedback.

Thanks

Community feedback

P
Grace 27,950

@grace-snow

Posted

Hi Seyide,

Well done on completing your first challenge!

To improve this project I think you should not use viewport units for font size or pixels so much for paddings. The text is very small on mobile, and things seem off center (although it is hard for me to tell exactly why while looking on my phone)

The other thing to change are those social links. They should be links really not just icon fonts, and should have a name available to assistive technology to say where each link goes. I would give them a matching width and height too so they stay circular not oval.

Last thing - add focus states to all interactive elements. That's an important one 😉

That's all from me, keep going, keep learning and have fun while you do!

0

@SeyideHundeyin

Posted

@grace-snow Thank you so much for the feedback. I appreciate it!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord