Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive landing page with CSS Grid

ROCKY BARUA 1,090

@Drougnov


Design comparison


SolutionDesign

Solution retrospective


Would love any kind of feedback. Especially if there's any better way to do this challenge. Thanks in advance :)

Community feedback

Omar Mohy 670

@omarmohy98

Posted

Hi@@Drougnov, wonderfully done! The code is remarkably responsive. Below is my feedback on potential improvements!

1.) your <a> tags not have discernible text that will make an accessibility issue, you can use aria-label="" to solve this problem, for example <a href="#"><i class="fab fa-facebook-f"></i></a> will be <a href="#" aria-label="Facebook Account"><i class="fab fa-facebook-f"></i></a>.

If you found my feedback helpful, please mark this comment as helpful. Wonderfully done. Happy coding!

Marked as helpful

1

ROCKY BARUA 1,090

@Drougnov

Posted

@omarmohy98 Thank you so much. I was worried about the accessibility issues cause I didn't know how to solve them. So thanks again. Going to fix them right now :)

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord