@crsimpson5
Posted
Hey Elaine, great job on your solution! You handled the element positioning really well, and it looks great on any screen size. A few tiny things you could improve:
- The dropdown arrow icons show a pointer, but they can't open the dropdown.
- The first cta button is getting stretched since the second one has a border, so the text isn't quite vertically aligned. It's only 2px off, but if it was a bigger border it would be more obvious. To fix this, you could use a custom property on the cta class for the border color and have it default to the background color.
- The attribution at the bottom could use a bit of line height on mobile.
Your solution is nearly perfect, so I could only find some tiny improvements π. Well done!
Marked as helpful
@elaineleung
Posted
@crsimpson5 Thank you Curtis, really helpful feedback here. My replies:
-
I kept reminding myself to add the arrow style changes and knew something was amiss when doing my final check, but I was just getting crosseyed from all the troubleshooting and thus missed the arrows. So thankful you spotted them! (Update: I just realized what you mean about the pointer! Sorry, total brain fart from staring at code too long to actually comprehend English anymore. Will fix this!)
-
Thanks for catching this one; I just changed them to
display: inline-flex
to center them and also added a custom prop, so hopefully that fixed it . Do let me know if you still see the issue there. -
More line height added for attribution on mobile
Thanks again, and I appreciate the check and feedback! Keep 'em coming π