@emestabillo
Posted
Hi BenChis, I'm not sure if I got your question, but were you looking for a way to make the mobile menu cover the entire screen? If so, I actually think you already answered your question :-) Try this on your ul
:
width: 100vw;
height: 100vh;
padding-top: 10%; (or whatever you prefer)
My other thoughts:
-
For the header text, I would delete the
span
tag wrapping the word 'THAT'. Remove the margins and place the entire heading text inside theh1
and add amax-width
so it would only stretch to a point. -
The first section under the header has duplicate
img
tags, one used for mobile and another for desktop. Look into<img srcset>
so that you are only using one tag. Here's an article -
The social media icons need to be wrapped in an
a
tag since they usually lead the user to another page. There's also a huge shift when hovering on them. Use the same technique as you did on the top and footer navs with the pseudoelement::after
so that the underlines are positioned beforehand rather than adding padding to create space between them and the item hovered on. -
The entire page might also need a
max-width
since it is expanding a little too much on larger screen widths.
Hope this helps!
@BenChis
Posted
Hi Emilie,
Thank you so much for your time and help!
Sorry, I think I did not make my point clear. What I meant is for my navigation menu the mobile version should have a black background when somebody clicks the toggle menu. I could nearly apply all css-rules on my .nav-toggle-label , but there is a problem occurring with my .navigation (Code-line 29) that it is not getting black when it should be black. (It is the parent where my elements are nested)
I have only one solution so far that does not solve it completely:
- I could put a black background on my .navigation codeline29 would solve the problem for making the whole screen black, but I can not decide when I turn it off or on, or is there a function that I could use to tell specifically the browser turn this background on when somebody clicks the .nav-toggle-label?
I applied all your advice and my layout looks better designed thanks again!!