Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive multi webpages using html, css and javascript

kyUu6i• 160

@hmhlol

Desktop design screenshot for the Space tourism multi-page website coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
3intermediate
View challenge

Design comparison


SolutionDesign

Solution retrospective


Although I am a noob, I tried my best at responsive pages.

Community feedback

P
Chamu• 12,970

@ChamuMutezva

Posted

Greetings Kyuu61. So far so good , but i have some reservation .

  • the project is an intermediate challenge and hence challenging and should not be of choice if you are just starting with coding. I will try to outline some of the short comings below.
  • use semantic elements where possible . Generally a site should have the main element as it contains the main content of the site. Interactive elements should be buttons and anchor elements, an image should not be used as an interactive element, rather you can put an image inside an interactive element. I am referring to the code below
<div class="nav_col1">
        <div class="col1-col">
          <img src="assets/shared/logo.svg" alt="" onclick="home()">
          <span></span>
        </div>
<i class="fas fa-bars" onclick="showMenu()"></i>
  <i class="fas fa-times" onclick="hideMenu()"></i>
  • use heading elements sparingly. The best practice is to have only one h1 element per page, heading elements should then follow a sequential order without skipping headings.
  • The site is generally not responsive, some elements are sitting on top of other elements. Check that when you open the navigation menu on mobile view.
  • the desktop view looks good.

I would recommend to do smaller challenges first and get the basics in order

Good lucky

Marked as helpful

0

kyUu6i• 160

@hmhlol

Posted

@ChamuMutezva Thank you for your feedback. I noted the points I missed. Please give me the feedback for other pages. I appreciate it.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord