Greetings Kyuu61. So far so good , but i have some reservation .
- the project is an intermediate challenge and hence challenging and should not be of choice if you are just starting with coding. I will try to outline some of the short comings below.
- use semantic elements where possible . Generally a site should have the
main
element as it contains the main content of the site. Interactive elements should be buttons and anchor elements, an image should not be used as an interactive element, rather you can put an image inside an interactive element. I am referring to the code below
<div class="nav_col1">
<div class="col1-col">
<img src="assets/shared/logo.svg" alt="" onclick="home()">
<span></span>
</div>
<i class="fas fa-bars" onclick="showMenu()"></i>
<i class="fas fa-times" onclick="hideMenu()"></i>
- use heading elements sparingly. The best practice is to have only one h1 element per page, heading elements should then follow a sequential order without skipping headings.
- The site is generally not responsive, some elements are sitting on top of other elements. Check that when you open the navigation menu on mobile view.
- the desktop view looks good.
I would recommend to do smaller challenges first and get the basics in order
Good lucky
Marked as helpful
0
kyUu6i• 160
@hmhlol
Posted
@ChamuMutezva Thank you for your feedback. I noted the points I missed. Please give me the feedback for other pages. I appreciate it.
0