@correlucas
Posted
👾Hi @lauryne921, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!
Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:
- Use
<main>instead of a simple<div>this way you improve the semantics and accessibility showing which is the main block of content on this page. Remember that every page should have a<main>block and that<div>doesn't have any semantic meaning. - Replace the
<h2>containing the main title with<h1>note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level. - Add a margin of around
margin: 20pxto avoid the card touching the screen edges while it scales down. - Reduce your code by removing unnecessary elements. The HTML structure is working but you can reduce at least 20% of your code by cleaning the unnecessary elements, you start cleaning it by removing some unnecessary
<div>. For this solution you wrap everything inside a single block of content using<div>or<main>(better option for accessibility) and put inside the whole content<img>/<h1>and<p>.
<body>
<main>
<img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor" >
<h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>
Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR
✌️ I hope this helps you and happy coding!
Marked as helpful
@lauryne921
Posted
@correlucas Hi ! Sorry for the late response but thank you to help me with the different projects ! So I change the <div> by <main> and yes I did some mistakes that I don't do usually like for the title <h1> but thanks to tell me. The margin: 20px you tell me to add is for the title ?
Once again thank you !
By the way, I checked your solution and I love it, you even added a light mode, that's cool
