Responsive sign-up using Angular

Solution retrospective
Feedback will be great!
Please log in to post a comment
Log in with GitHubCommunity feedback
- @EDrick-her
Hi! To be honest, I don’t understand the project very well because I don’t know Angular or JSON, and there are a lot of folders whose purpose I’m not familiar with. So I’ll just suggest a few things based on what I do know and areas I believe you can improve on:
The most important thing here is the form. You can build it natively using HTML so that, when the user enters an incorrect email, the browser will automatically show an error and prompt them to enter it correctly.
Additionally, you could also use JavaScript with a regular expression (regex) to validate the email input, like this: const emailUsuario = document.getElementById("email").value; const emailValido = /^[^\s@]+@[^\s@]+.[^\s@]+$/.test(emailUsuario); This code grabs the email the user enters and performs a simple validation check.
I mention this because, in your current implementation, I was able to enter something like hi@h and it still let me through even though hi@h isn’t a valid email (it’s missing a domain like gmail, hotmail, outlook, etc.).
Lastly, I noticed some minor issues with hover effects when clicking the button. But honestly, I couldn’t locate the specific problem due to the number of folders again, that’s on me. I’m just not sure why there are so many files.
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord