Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive social section with flex

Tiass 295

@Tiasstiass

Desktop design screenshot for the Social proof section coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I have the impression that i made it really complicated when it should not be. Tell me how could i make it easier. Every feedback appreciated!

Community feedback

P
Katrien S 1,070

@graficdoctor

Posted

Hi Tiass, You actually have a neat-looking design there. Though I do indeed see in your css you've gone a bit overboard with the media-queries.

  • Start working mobile-first. And think about your breakpoints. FreeCodeCamp wrote an article on that.
  • Set a max-width on your body. At some point you want the content to stop growing and be in its place. Enlarge your screen in your dev tools and see what happens when it gets really really big.
  • To make your page more responsive; try to set your margins & paddings in (r)em, your font-size in rem and your widths in %. Pixels are strict values, they don't change.
  • Instead of adjusting the margins on bottom-boxesand hero-ratings I was tipped to use transform: translate().

But your code reads lovely. It's well-organized. Nice one. Happy coding!

2

Tiass 295

@Tiasstiass

Posted

@graficdoctor Thanks for the feedback, will definitely look more into that.

0
Luke 220

@lukebergmann

Posted

Wow, this is pretty perfect! Incredible job!

0

Tiass 295

@Tiasstiass

Posted

@lukebergmann Thanks :)

0
P
ApplePieGiraffe 30,565

@ApplePieGiraffe

Posted

Hey, Tiass! 👋

Nice job on this challenge! Your solution looks pretty good and is responsive! 👍

Like graficdoctor mentioned, setting a max-width on the content of the page would be a good idea, and I think adding some margin or padding between the heading + paragraph text and the review boxes in the desktop layout would be nice to prevent the two from coming so close together when the width of the screen decreases.

Keep coding (and happy coding, too)! 😁

0

Tiass 295

@Tiasstiass

Posted

@ApplePieGiraffe Good to know, thanks :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord