Results summary component using HTML and CSS

Solution retrospective
I am most proud of the fact that I wrote the entire code for this challenge without seeking for external assistance. Which means I have significantly improved in my frontend development journey. I find the challenge quite simple enough. So, I planned on the design, and used only HTML5 and CSS to complete the challenge.
What challenges did you encounter, and how did you overcome them?One of the challenges I encountered was that the content of one of the div
was shrinking while the other remained the same as the screen size reduced. It turned out that I had used viewport
values for its size i.e 60vw
. So I changed it to percentage - 60%
.
I am comfortable with my project right now, however, if there is anything I could do better I'd really love to know.
Please log in to post a comment
Log in with GitHubCommunity feedback
- P@huyphan2210
Hi, @Caleb-Abuul
I checked out your solution and I have some thoughts:
- "Your Result" Section: It seems the height of this section shrinks on viewports
1024px
wide or larger. This is due to an invalidgrid-template-rows
value in the media query. You can fix this by settinggrid-template-rows: unset
, which will help avoid the current setting ofgrid-template-rows: 40% 60%
that's used for mobile viewports. - HTML and Body Sizing: Setting
width: 100vw
onbody
andhtml
isn’t necessary since these are block-level elements that already fill the full width. Also, consider usingmin-height: 100vh
instead ofheight: 100vh
onbody
to ensure content expands appropriately on all screens. - Semantic HTML: You’re already using
main
andfooter
tags, which is great! To improve accessibility and structure further, try replacing genericdiv
s with more descriptive tags likesection
orarticle
where relevant.
Hope this helps!
Marked as helpful - "Your Result" Section: It seems the height of this section shrinks on viewports
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord