Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 2 years ago

Results Summary Page Design

Burcin•120
@burcinalim
A solution to the Results summary component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I am open to all your suggestions to improve myself. Please share your comments with me. :)

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Guerinik Abderrahmane•460
    @AbderrahmaneGuerinik
    Posted almost 2 years ago

    Great component ! you can improve your code by : -using semantic html like main instead of div.

    • using rem unit instead of px. -using BEM methodology for naming classes in CSS. -using variables in CSS. -setting the margin and padding of all elements to 0 and box-sizing to border-box to avoid undesirable problems.

    Enjoy coding !

    Marked as helpful
  • _nehal💎•6,710
    @NehalSahu8055
    Posted almost 2 years ago

    Hello Coder 👋.

    Congratulations on successfully completing the challenge! 🎉

    Few suggestions regarding design.

    • Remove commented code below as this will not dynamically center the card use flex or grid
    .container {
        display: flex;
        min-height: 100vh;
        align-items: center;
        justify-content: center;
        
        /* position: absolute; */
        /* top: 20%; */
        /* left: 35%; */
    }
    
    • You are misusing <nav> nav is used for sidebar, navigation bar, or drop-down menu for any navigation link purpose.

    • In the mobile layout your card is left aligned

    • Use max-width instead of width to make your design responsive.

    I hope you find this helpful.

    Happy coding😄

    Marked as helpful
  • Divine Ugorji•350
    @DivineUgorji
    Posted almost 2 years ago

    Hello, and congratulations on completing this challenge. Your implementation is nice, however, I have a little suggestion to help you in your future projects.

    I observed that you used generic words for some of your class names, and short forms such as ctgry, ctgry-name, panel1, and panel2, to point out just a few. It's always a good practice to use semantic naming in your projects. This means that you need to name your classes within the context of the project you're building. Use more creative names for your text areas instead of text1, and text2. This skill helps to reduce the effort needed to read and understand your code which comes in handy when working with a team.

    You can also check out BEM, which is a widely accepted naming convention out there.

    I hope my suggestion helps, happy coding, and good job on this project!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub