Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Room - homepage

Imran 105

@imRAN-1998

Desktop design screenshot for the Room homepage coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
3intermediate
View challenge

Design comparison


SolutionDesign

Solution retrospective


Open for suggestions :)

Community feedback

P
Chamu 12,970

@ChamuMutezva

Posted

Well done on completing this challenge, generally the mobile and desktop version is looking good but in between (medium devices) the presentation needs attention as some elements are overlapping into others. Another point to note (personally) - a continuously animation can be a pain to the eyes of others and would prefer an animation that is of a short time or something that runs after a while not in continuous succession. Look into semantic elements as well instead of using divs for example the nav section can use the nav element as a parent with some ul and li tags as children. Semantic elements has an advantage when it comes to accessibility among other things. The first heading on a website has to be an h1 followed with an h2 in that order , it is not recommended to start with an h5 or h6 and down the project you fit in an h1 tag - that also has to do with accessibility.

Happy coding

2

Imran 105

@imRAN-1998

Posted

@ChamuMutezva Thank you for your wonderful feedback Mr.chamu, was expecting this kind of feedbacks to learn more. And will work on my coding knowledge and will produce a well structured code.

0

@ChayalaKaufman

Posted

nice work!

1

Imran 105

@imRAN-1998

Posted

@ChayalaKaufman thank you :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord