SCSS, CSS Grid, bonus tablet layout

Solution retrospective
I decided to create a tablet layout as well, rearranging the grid for widths around 768px. I think it came out pretty good, but feedback is appreciated.
Please log in to post a comment
Log in with GitHubCommunity feedback
- @mattstuddert
Amazing work on this challenge, James! You've done an awesome job matching the design, and the additional layout switch you've created for tablet sizes looks great!
One small thing I'd recommend would be to change the
alt
attributes for the testimonial avatars, as they don't any extra context for screen reader users. At the moment, "user thumbnail" will be read for each testimonial, when the person's name and the fact they're a "verified graduate" is the key information. Changing toalt=""
will make screen readers skip those avatar images.Keep up the great work! 👍
- @ApplePieGiraffe
Hello, James English! 👋
Wow—great work on this challenge! 👏 You've done a wonderful job in matching the design preview (just about pixel-perfect) and the intermediary layout that you added works really well! 👍 Your code is looking good, too! 🙌
Keep coding (and happy coding, too)! 😁
- @tediko
Hello, James! 👋
Congrats on finishing another challenge and also on getting featured in newsletter. I would suggest you to take a read about BEM modifiers,
.testimonial__grayish
.testimonial__white
etc, are your modifiers so you should name them like.testimonial--grayish
etc because those are flags on blocks or elements. Use them to change appearance, behavior or state. Also, read about Sass 7-1 pattern to keep your file management orginazed.Good luck with that, have fun coding! 💪
- @mathcrln
Beautiful implementation and your code is also clean and organized, well done! 👏🏾
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord