Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

signup with success message

styled-components, vanilla-extract
Shakeel Ahmad•60
@Shakeel-Coder
A solution to the Newsletter sign-up form with success message challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


i tried my best as i am the beginner in the front-end development. but i miss some serious issues such as email validation before submit and back from success message. i tried hard but i didn't know how to do this. so please if you have submitted this solution and know how to do this give me the some suggestion about that. i hope you check and give me the feedbacks.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Ludzik•170
    @Ludzikk
    Posted over 1 year ago

    Hello, im not good at giving advice, but i'll try my best. So to validate email you will have to check if email in input is correct on click on button. So if it's correct after checking regex.

    Function you are trying to run on dismiss button named: dismissMessage() is not defined.

    To close popup msg, simply remove "hide" class from your submit form and add "hide" class to popup msg.

    If you need more help msg me on discord it's linked on my github.

    Marked as helpful
  • P
    enzmrg 💫•920
    @enzo-mir
    Posted over 1 year ago

    Hello there, nice challenge ! There are a lot of things to say but firstly :

    • Try to avoid div element and use instead html sementics tag
    • Your parents elements : body, div#main got no height to be the container and you can not easily center the main content
    • Set min-width to your containers it will help for responsive

    I guess that is your first FrontEnd Mentor project ? Well donne ! ;)

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub