Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

single page application with vanilla javascript

RaulTCβ€’ 260

@Raul-TC

Desktop design screenshot for the REST Countries API with color theme switcher coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
4advanced
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello everyone, this is the first project that I dare to publish, I still have no experience with github, any suggestion or question is welcome, PS: I'm using google translate. :)

Community feedback

Travolgi πŸ•β€’ 31,460

@denielden

Posted

Hi Raul, good job! I took some time to look at your code and have some ideas for improving it:

  • img element of moon must have an alt attribute, it's very important!
  • to make all flag images the same height use the object-fit: cover and aspect-ratio: 3/2; property
  • instead of using px try to use relative units of measurement -> read here
  • if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
  • I would also add a query reset button, I find it very convenient

Overall you did well πŸ˜‰

Hope this help and happy coding!

1

RaulTCβ€’ 260

@Raul-TC

Posted

@denielden Hi Daniel, thanks for the comments, I'll be working on it, thank you very much.

1
P
Chamuβ€’ 12,970

@ChamuMutezva

Posted

Hi Raul. Your solution looks good, look into the errors from the automated feedback. Some of the errors include

  • Images that has no alt attribute
  • empty srcset values
  • A missing h1 heading element.

I cannot view you github repository as I am getting a 404 error message. It may be because you repository is set to private

1

RaulTCβ€’ 260

@Raul-TC

Posted

@ChamuMutezva Hi Chamu, I fixed the repository link, thanks for the feedback :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord