Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Single Price Grid Component (CSS Grid + Some Flex)

Mike 115

@maquinde

Desktop design screenshot for the Single price grid component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Can I have some feedback on my HTML & CSS? I feel like my CSS could be cleaner...

Thank you in advance!

Community feedback

P
Matt Studdert 13,611

@mattstuddert

Posted

Hey Mike,

Great work on this challenge and congrats on submitting your first solution! Here are a few pointers for your HTML code:

  • The "$29 per month" text shouldn't really be in two separate paragraphs. I would just have a single paragraph and then add a span to separate the words. span elements have no semantic meaning, so they're great for these purely visual tasks.
  • You don't need the .overlay element to change the background in the "Why Us" area. Instead, you could just change the background-color.
  • In the "Why Us" area you've got the items in paragraph tags, whereas I'd say this should be a ul as you'd describe it as a list of features/benefits.

I hope those tips help. Let me know if you have any questions!

2

Mike 115

@maquinde

Posted

Thank you for the feedback! This is what I was looking for!

0

@simeon4real

Posted

Your solution looks good. About your HTML5 and CSS code, I think It will be better if you apply BEM - Block Element Modifier to your solution. It will make your markup more semantic. Also, I recommend using classes to style elements. for your headings, You can use a class like .heading__primary { __code here__}

This article on SmashingMagazine will help with that.

Don't forget to upvote my feedback if you found it useful

2

Mike 115

@maquinde

Posted

Thank you! I really appreciate the feedback.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord