Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 4 years ago

Site using HTML, CSS and JavaScript

Raj Mhatre•215
@RajMhatre20
A solution to the Manage landing page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


  1. How do I change the hamburger after opening nav in mobile design.
  2. Why the background in the body disappears after opening nav in mobile design
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Agata Liberska•4,075
    @AgataLiberska
    Posted over 4 years ago

    Hi @TajMhatre20, for your hamburger button question - you could add another image and toggle visibility on click, or just change the src attribute of your <img> element on click. However, I need to point out that you're using a <div> for this element which makes it inaccessible - it should be a button or a link, really. Also, the items in your nav should be links and not plain text (I would put anchor tags inside the list items you have).

    Hope this helps! :)

  • Roc Tanweer•2,500
    @RocTanweer
    Posted over 4 years ago

    Hello 👋, For ham button, you may research on codepen.io or you can also see my Easybank project solution, I believe my extremely DRY method of writing sass code is reader friendly.

    For background-image problem... You yourself has made background-image to none in js file... I would suggest put an overlay over the body when ham btn is toggled...you may also apply linear gradient as you tried in js file... You may watch coder coder on yt EasyBank project... She has the solution to your problem

    Hope it helps Happy coding!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub