Social links profile

Community feedback

• 

  P

  Øystein Håberg•13,260

  @Islandstone89

  Posted 3 months ago

  Great job, Sascha!

  I've only had a quick look, but I don't see any issues in your CSS.

  A few things in the HTML:

  • "Front-end developer and avid reader." should be a <p>.

  • The social media links should be an unordered list:

  <ul class="social-media-links">
    <li><a href="" class="sm-button text-preset-2-bold">GitHub</a></li>
    <li><a href="" class="sm-button text-preset-2-bold">Frontend Mentor</a></li>
    <li><a href="" class="sm-button text-preset-2-bold">LinkedIn</a></li>
    <li><a href="" class="sm-button text-preset-2-bold">Twitter</a></li>
    <li><a href="" class="sm-button text-preset-2-bold">Instagram</a></li>
  </ul>
  

  You are doing great, keep up the good work :)

  10

  Marked as helpful
• 

  P

  M Kerr•2,130

  @mkerr-github

  Posted 3 months ago

  Good job, looks great!

  "Is it common to use border-radius with pixel values?"

  For responsive purposes the usual convention is to convert most pixel measurements to "rem". To do so divide them by 16 (as the base rem is 16px based on the default font size setting on most browsers).

  Then use "max-width:" to set the larger width (for desktop) and "min-width :" to set the smaller width (for mobile).

  The convention of using use rem and sometimes em as much as possible, instead of pixels for most items (including most border radii), is because rem and em are more responsive. Pixels can be used for small elements like icons and buttons where you do not want the size to change even on small screens.

  More details here: https://austingil.com/px-or-rem-in-css/#:~:text=Pixels%20are%20an%20absolute%20unit,the%20equivalent%20of%2024%20pixels.

  If you found anything in this comment helpful, please remember to click "mark as helpful", thank you!

  Keep up the good work, and keep going! 👋

  10

  Marked as helpful