Skip to content
Submitted 11 months ago

social-links-profile using HTML and CSS

Firdoshi•20
@Firdoshi
A solution to the Social links profile challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

What are you most proud of, and what would you do differently next time?

All feedbacks are welcome. Thank You in advance

Code

Please log in to post a comment

Log in

Community feedback

  • P
    Boris•4,130
    @makogeboris

    Great work @Firdoshi, here are a few things to review

    • All content should be wrapped within landmarks. Wrap a main tag around the .container. It's not good practice to wrap every elements in div because divs aren't semantic. Use Semantic Elements
    • To improve the semantic meaning of these social media links, you should use the a (anchor) tag instead of the button tag. The a tag is used for navigation to other pages, while the button tag is designed for interactive actions like submitting forms or for events like toggling content. Also, using an unordered list ul to group the social media links is a better approach for both semantics and accessibility.
    • Font-size should be written in rem not px
    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord