Skip to content
Submitted 3 months ago

Social links profile using tailwindcss, next.js, flexbox

next, react, tailwind-css
P
BlonoBuccellati•310
@BlonoBuccellati
A solution to the Social links profile challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

What are you most proud of, and what would you do differently next time?

The speed at which I build UIs is increasing, and I am now able to make finer adjustments.

By the third project, I have finally gained enough confidence to consider various aspects, such as which components should have explicit size specifications and which should not.

What challenges did you encounter, and how did you overcome them?

Even after building the UI, I was unable to make fine adjustments. This was because I needed to specify the line height using leading-normal instead of relying on the default line height.

In this project, I identified and resolved the issue by carefully inspecting each element with DevTools to find discrepancies.

What specific areas of your project would you like help with?

I would like to understand which elements should have explicit size specifications.

In this project, I assigned a specific size to the Card, specified the height for the button, and set its width to w-full.

The reason behind this approach is that child elements should adapt to their parent elements. However, I also considered that buttons should maintain a consistent height regardless of their parent, which is why I explicitly set the height for them.

Does this approach align with best practices? Additionally, is my CSS implementation appropriate?

If you have any insights, I would greatly appreciate it.

Code

Please log in to post a comment

Log in

Community feedback

  • P
    Boris•4,110
    @makogeboris

    Great work, generally speaking you shouldn't explicitly set fixed sizes on elements (except for images when necessary) as this can create problems with responsiveness and content fit. Instead, let the content and padding determine the element’s size. If necessary, use max-width or min-height, and prefer relative units like rem for better adaptability.

    • Your card should have a max-width in rem and no height.
    • For the buttons use padding to determine its size not height and to improve the semantic meaning of these links, you should use the a tag instead of the button tag. The a tag is used for navigation to other pages, while the button tag is designed for interactive actions like submitting forms or for events like toggling content. Also, using an unordered list ul to group the links is a better approach for both semantics and accessibility.
    • All content should be wrapped within landmarks. Wrap a main tag around the card

    Hope this helps, Good luck!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord