Social Media Dashboard using HTML, SCSS, JS

Community feedback

• 

  Raymart Pamplona•16,040

  @pikapikamart

  Posted almost 4 years ago

  Hey, awesome work on this one. The layout looks really good, it responds well and the mobile layout is really good. Cards are just bit bigger that's why 4 cards won't span in single row.

  First, to be honest, I still find this challenge hard especially choosing semantic elements.

  Some suggestions would be:

  • For better accessibility, the color theme toggler should be using a fieldset as the parent container, and having legend:

  <fieldset>
    <legend> colormode selections </legend>
    <label />
    <radio />
    <label />
    <radio />
  </fieldset>
  

  The structure would look like that. When screen reader navigates in that, it would read the legend element, informing a user what this set of input does, hence it is for color mode selection.

  • input type="radio" will be the best element on this, since it is a choices right, radio buttons are intended for those. You can look at my rest-api-challenge, look up the structure of my color modes toggler. If you want a simpler one, like this challenge's color mode selection, you can reply to this feedback and i'll be gladly make a code snippet so that you can use it as your component.
  • Great adding sr-only text for the main element.

  Aside from those, great work. I still can't make decision what element I would use on this hahaha my first version of this is not really accessible at all. Great work!

  06

  Marked as helpful