Social proof section using semantic HTML and Sass

Community feedback

• 

  

  Grace•32,130

  @grace-snow

  Posted almost 4 years ago

  Hi

  This looks great for such an early challenge. I would try to fix the alignment to match the design on desktop to make it look more polished/finished. See how everything aligns at the top and on both sides in the design? Designers are insistent with details like that as it's a core principle of good design ☺

  In the html

  • if you use section, you have to include a heading. On this design it would need to be a screenreader only one. But as all content on this is related, I'm not sure 2 sections are necessary
  • remember uls are block elements already. Only wrap in an extra div if you need to
  • if multiple footers are used on a page, they all need aria-labels (even if used within an article/blockquote) I would probably advise wrapping the quote in a figure and using figcaption instead for the author info, or making that author info into a heading above the quote... Bottom line is there is no fully accepted standard for this type of content but figure > blockquote + figcaption seems to most widely accepted as correct these days

  I hope that helps

  02

  Marked as helpful
• 

  P

  Patrick•14,265

  @palgramming

  Posted almost 4 years ago

  ⭐⭐⭐⭐⭐ Look really nice... Great Job!!

  11
• 

  Anurag Singh•1,265

  @exist08

  Posted almost 4 years ago

  perfect

  11