@emestabillo
Posted
Hey @hebrerillo, this looks visually solid, congrats!
The only thing that I noticed is the use of semantics, especially headings, on each page. We're missing the h1
s here and the heading levels doesn't seem to be in order (ex. h5 is mentioned first before h2). Use class
es to style your headings (or anything for that matter), instead of looking at 'how large' they look on the design and assigning a heading tag. Here's a resource regarding the headings.
Hope this helps!
Marked as helpful
@hebrerillo
Posted
@emestabillo thank you for your feedback!!
I only had the 'h1' tag in the home page but was missing in the rest of the pages. Now I added the 'h1' tag in the rest of the pages.
I also updated the order of the headings. For example, now 'h3' tag is before 'h4' tag. Is that what you meant?
I made a commit with your suggested changes. Could you please take a look?
Thank you so much!!