Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 4 years ago

Stats Preview Card Component Main

tony_•70
@onmywayfromwestindies
A solution to the Stats preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hi everyone, here my solution from Frontend-mentor-stats-preview-card-component-main challenge.

So, please, check my code.

I wish to have your feedbacks to improve my skills.

Happy coding !

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Raymart Pamplona•16,040
    @pikapikamart
    Posted almost 4 years ago

    Hey, awesome work on this one. Layout in desktop looks fine, though the responsiveness and the mobile state could be better since the contents are being hidden and creating horizontal scroll.

    Michal already gave great suggestions on this which I agree as well. Just going to add some suggestions on this one as well.

    • Always have a main element to wrap the main content of your page. On this one, the .container should be using the main instead of div.
    • Also, there is an extra div as a first child of the body tag, you don't really need that one since you could have made use of the right-section-image be using like a picture tag so that the img will change according to what screen-size is in now.
    • I would prefer the body tag using a display: flex on this, but I can't suggest directly since like I said, there is an extra div. But if you remove the div consider making the body a flexbox to which it will center the content properly.
    • The text after the h1 should be using p tag since they are just regular text.
    • Your .box-numbers could have used ul since those are "list" of information about the company website.
    • Also, inside in those list information, those text should not be using a heading tag because they don't really give content on what the section would contain right, so better using p tag on them.
    • Lastly, maybe a better/descriptive value for the image's alt attribute.

    Aside from those, great work again on this one. If you have queries, just drop it here okay,

    Marked as helpful
  • MichalTrubini•1,220
    @MichalTrubini
    Posted almost 4 years ago

    Hi Tony,

    I am also a beginner so don't take my advice as the advice of an expert.

    Your site does not work on mobile. By the looks of it, first you completed the desktop version and then scaled down by using media queries with max-width. I would suggest starting from bottom-up, that is a mobile-first approach. Then, when scaling up, use media queries with min-width.

    Furthermore, move from px to rems, don't set widths to fixed numbers like 700px, unless it makes sense sense or is justified because you might end up with horizontal scrolling on mobile.

    Also, when using header tags it is a good practice not to jump from h1 to h4. Instead, I would use h1 --> h2.

    Hope this helps.

    Michal

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub