Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 2 years ago

Stats Preview Card Solution + HTML + CSS + FlexBox + CSS GRID

accessibility
P
Kamaniaβ€’170
@Kamania
A solution to the Stats preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hello there! Check out my work and provide any feedback on areas I can improve on. Thank you

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Zubair Abidβ€’280
    @ZubairAbid101
    Posted almost 2 years ago

    Hello!!! πŸ‘‹

    Congratulations on completing the challenge! πŸŽ‰

    There are some things that you can improve in the code,

    • I noticed that you used the same styling for the <html> and the <body> element in your CSS file. I advise removing the <html> tag from your styling as this will not change the appearance of the design.
    • Try using the prescribed image given for each viewport. A simple way to do this is to create two <img> elements, one for the desktop and other for the mobile design. Set the display: none for the mobile design as default. Then using media queries set it to display: block for the mobile design at the appropriate size.
    • Instead of creating a single media query, try making separate media queries inside each individual element in your CSS file.
    • Try using min-height: 100vh on the <body> element. This will give you more control over how the document behaves provided the height gets larger than 100vh

    I hope you find this comment helpful! πŸ™‚

    Did you know that there's a mark as helpful and an up-vote option? πŸ€”

    There's even a Follow button!!! 😁

    Happy Coding!!! πŸ’»

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
Β© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SASS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up β€œinvalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub