Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

SunnySide Agency Landing Page

Dev Ubong 395

@ubong-s

Desktop design screenshot for the Sunnyside agency landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


This challenge is in sneakily time consuming. Fun too. Will appreciate some feedback. Cheers

Community feedback

P
Chamu 12,970

@ChamuMutezva

Posted

  • use semantic elements where possible, using a div in the place of an interactive element(in this case a button) is not beneficial to assistive tech users.
  • the following elements has been duplicated (some for mobile and some for desktop) - in my opinion that is not best practice in terms of responsive design. View the structure of your html without your css and try to check on the flow.
<ul>
                  <li><a href="#">About</a></li>
                  <li><a href="#">Services</a></li>
                  <li><a href="#">Projects</a></li>
                  <li><a href="#" class="nav-btn">Contact</a></li>
               </ul>
  • look into responsive images techniques (picture element, srcset) when you want to switch images between mobile and desktop , avoid the following kind of display:
 <img
               src="./images/mobile/image-transform.jpg"
               alt="transform"
               class="mobile"
            />
            <img
               src="./images/desktop/image-transform.jpg"
               alt="stand-out"
               class="desktop"
            />
  • alt values have to be descriptive to benefit assistive tech users (they should be able to visualize the message that is being put across)
0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord