Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

SunnySide Agency Solution

@Hemsundar15

Desktop design screenshot for the Sunnyside agency landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any feedback would be great!!!

Community feedback

Amon 2,560

@A-amon

Posted

Great work! It's responsive too~😀

Here are a few suggestions:

  • Place all your <section> inside <main>
  • As stated in the Accessibility Report, seems like you're jumping around the heading tags order quite a bit. To fix this, increase your heading tag by only 1 as the nesting goes deeper. For example:
<section>
  <h2>Title</h2>
  <div>
    <h3>Sub-Title</h3>
    ...
    <div>
      <h4>Sub-sub-title</h4>
      ...
    </div>
  </div>
</section>

^ This is just my understanding though so do read up on it for more accurate explanation 😀

  • Your .nav__hamburger 🍔 should be a <button> instead of a <div>.
  • The <a> tags that wrap around the icons and logo should have a text describing where it links to (For screen reader users) 🔊. And since this text is hidden visually 👻, I usually would use aria-label attribute on the <a> tag. But you can also solve this by adding sr-only class (and do its CSS) to hide the text Reference.
  • Oh, and seems like there are no hover effects on the links (only the 'Contact' button has it) 🤔

Marked as helpful

2
Amon 2,560

@A-amon

Posted

404 repository link 😂

0

Amon 2,560

@A-amon

Posted

@Hemsundar15 Maybe you either don't have the repository inside your Github or the visibility is set to private 👀

Marked as helpful

0

@Hemsundar15

Posted

@A-amon Oops, sorry I didn't notice that! Changed it to the public now. Thanks!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord