Magda• 235
@magdaszsz
Posted
For inline svgs I usually do svg path { fill: color}
1
Luis Colina• 1,043
@Comet466
Posted
@magdaszsz thank you Magda, knowing that help me out in another challenge that i just started
0
Design comparison
Solution retrospective
i was gonna take a break but as soon as i watch his layout i had to do it, a love the color palette and i always enjoy doing grid layouts, can somebody tell me a proper way to change the color of SVG elements? i try my best with the filter property but didnt quite match the color of the footer logo, happy coding
Community feedback
P
ApplePieGiraffe• 30,545
@ApplePieGiraffe
Posted
Hi there, Luis Colina! 👋
Good job on this challenge! 👏 Your solution looks very nice and I really like the animations you added to the content of the page and the mobile menu! 😀
One small thing I'd like to suggest is adding overflow-x: hidden to the body to prevent a horizontal scroll bar from appearing along the bottom of the page when some of the animations play.
Also, a little padding around the text of the reviews near the bottom of the page would be nice so that the text isn't right up against the edge of the screen in the mobile layout. 😉
Keep coding (and happy coding, too)! 😁
1
Luis Colina• 1,043
@Comet466
Posted
@ApplePieGiraffe thanks applePie
0
Well it looks good 2 things I noticed
-
the mobile menu when open drops down pretty far away from the hamburger button
-
the ground of 4 images near the footer are not square shaped in mobile view at 375px wide browser
But great job on this challenge
1
Luis Colina• 1,043
@Comet466
Posted
@palgramming hello patrick i already fixed the hamburger menu and the 4 ground images looked really stretched cause of a way too big min-height property that was set, thanks for pointing out those flaws
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord