Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Sunnyside Landing Page (HTML, SCSS, JS)

Amonβ€’ 2,560

@A-amon

Desktop design screenshot for the Sunnyside agency landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello! I got a few questions: πŸ€”

  • How to increase svg's height and width (without cropping it)
  • How to remove the empty gaps/spaces on .images__image

Any other feedback are welcome! (Especially on semantics and accessibility πŸ˜‚)

Community feedback

Mark Mitchellβ€’ 1,820

@markup-mitchell

Posted

  • use viewbox. eg your social media icons: remove width="20" and height="20" and use viewbox="0 0 20 20" instead. Now use CSS to set width/height in whatever units you like.
  • images are displayed as inline elements by default and the gap at the bottom is for text descenders. Use display: block or vertical-align: middle on your img elements.

I didn't look at your semantics and accessibility in much detail; I'm suspicious of aria tags as they're often unnecessary and can make things worse if misused, but hiding the SVG and labelling the link seems like a safe bet to me. Good effort!

Marked as helpful

1

Amonβ€’ 2,560

@A-amon

Posted

@markup-mitchell Thank you! Tho I had to manually adjust the viewbox values to get the right size πŸ˜‚

0
Danielβ€’ 250

@daniel-hennig

Posted

I really love the animations and the parallax effect. The code looks semantic as well!

I've found just one little issue when you go to 1800px wide screen and larger: The position of the image of .hero {background-image} is downwards quite too much in my opinion, so that you can barely see the orange fruit. Maybe you can increase the background-position-y and the height of .hero by some vw-units. Usually I try to make my projects responsive/fluid up to 3000px since a lot of my friends have really large screens.

Awesome solution, anyway, my debugging-friend!

Marked as helpful

0

Amonβ€’ 2,560

@A-amon

Posted

@daniel-hennig Thank you! I didn't notice the issue on larger screens πŸ˜‚ I changed the background-position to bottom and I think that solved it. πŸ˜€

Glad you like the animation! I spent my time, thinking on what to animate (I know it's weird to spend time on this~πŸ˜‚)

1
Danielβ€’ 250

@daniel-hennig

Posted

@A-amon background-position to bottom is even better. Very good!

Well for me it's not weird at all to spend some good time on animations, because animations are just making so much fun, therefore I completely understand youπŸ˜„

0
Amonβ€’ 2,560

@A-amon

Posted

@daniel-hennig That's so true! πŸ˜‚

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord